chore: add missing dependencies #31309
Conversation
Adds a few missing dependencies which were previously picked up thanks to sibling monorepo packages having the same dependency.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
LGTM
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Maybe what we could consider and investigate is remove more dependencies from |
|
View your CI Pipeline Execution ↗ for commit 3be46b4.
☁️ Nx Cloud last updated this comment at |
|
knip is already detecting this, isn't it? 👀 I thought that's how we got the warnings before. it detected that the sub-packages didn't have the right dependencies, even though maybe I'm mistaken :D |
|
lol yes I forgot about strict mode, and didn't use that in my latest PR here unfortunately. Comes with more strictness, isolated packages should probably be separate flag. So many projects, so many setups. |
|
does this need to happen still @ndelangen ? 🤔 i wonder if its all already been solved since |
3 participants
Adds a few missing dependencies which were previously picked up thanks to sibling monorepo packages having the same dependency.
cc @webpro
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Basically ensure the build still succeeds.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.Greptile Summary
Updates package.json files across multiple Storybook packages to explicitly declare dependencies that were previously being implicitly inherited from sibling packages in the monorepo.
@types/estreetosvelte-vitepackage for ESTree AST type definitions@babel/coreto bothcreate-react-apppreset andreactrenderer packagesexpect-typev1.1.0 tovue3andreactrenderer packagesbrowser-assertandexpect-typetocorepackage@babel/typestovitestaddon package💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!